-
Notifications
You must be signed in to change notification settings - Fork 5k
Adding CSV Parser #1996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding CSV Parser #1996
Conversation
I am adding the CSV parser python code. it works with basic CSV files.
updating the csv parser code and importing the CsvParser class
Added CSV Test file
Formatted the file
Formatted the file
Looks like there are still a few ruff issues. |
You need to run |
The CI now fails on the mypy step. Here's what I suggest as the change to csvparser:
The next CI step is black. You can run The step after that is running tests. I think those are failing currently as you haven't brought in the current changes from the main branch. There should only be a single line difference in prepdocs.py, the line that adds CSVParser, but it's instead showing many lines changes. The CONTRIBUTING.md has details about how to run these steps locally, by the way: |
Thanks
Thanks for the code. I added this. |
Have you made a commit with the changes to run black and to update prepdocs.py to match main? I only see the mypy commit, and CI is still failing. |
I've made a few changes to merge this with main, and it's now looking good. I've also tested it locally. It has the same drawback of other files where the browser downloads the CSV instead of rendering it, but that's not unique to the CSV file format. Merging! |
Thank you for helping me to push the files in the main. |
Purpose
Does this introduce a breaking change?
When developers merge from main and run the server, azd up, or azd deploy, will this produce an error?
If you're not sure, try it out on an old environment.
Does this require changes to learn.microsoft.com docs?
This repository is referenced by this tutorial
which includes deployment, settings and usage instructions. If text or screenshot need to change in the tutorial,
check the box below and notify the tutorial author. A Microsoft employee can do this for you if you're an external contributor.
Type of change
Code quality checklist
See CONTRIBUTING.md for more details.
python -m pytest
).python -m pytest --cov
to verify 100% coverage of added linespython -m mypy
to check for type errorsruff
andblack
manually on my code.